update arg_parser.py to fix --port argument type
#6
Conversation
| @@ -143,6 +143,7 @@ def get_parser(): | |||
|
|
|||
| parser.add_argument( | |||
| "--port", | |||
| type=int, default=0, | |||
There was a problem hiding this comment.
default 0 ? I think it's not even possible to use such port.
There was a problem hiding this comment.
perhaps there is no default value here, argument --port still equals to 0 even leave it empty.
There was a problem hiding this comment.
0 to 1023 are "well known ports" but there is no document that says 0 cannot be used and it has no official protocol assigned for neither TCP nor UDP. 0 is sometimes used (unofficialy) for specifying system allocated ports
|
build failed due to #4 |
|
someone could retry the build manually. I don't have such access rights anymore. |
|
can't reappear this test failure in local environment. |
I granted you access to ianitor back again. |
update arg_parser.py to fix `--port` argument type
|
Merged and released on PyPI as @pwilczynskiclearcode thanks for access grant! |
--portargument defualt type isstr, this will cause a consul register error.